Skip to content

Comments

Update pytorch (1.12.1), torchaudio (1.13.1), torchvision (0.12.1)#189013

Merged
mweinelt merged 5 commits intoNixOS:masterfrom
mweinelt:torch-1.12.1
Aug 31, 2022
Merged

Update pytorch (1.12.1), torchaudio (1.13.1), torchvision (0.12.1)#189013
mweinelt merged 5 commits intoNixOS:masterfrom
mweinelt:torch-1.12.1

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Aug 30, 2022 •
edited
Loading

https://github.com/pytorch/pytorch/releases/tag/v1.12.0
https://github.com/pytorch/pytorch/releases/tag/v1.12.1

https://github.com/pytorch/audio/releases/tag/v0.12.0
https://github.com/pytorch/audio/releases/tag/v0.12.1

https://github.com/pytorch/vision/releases/tag/v0.13.0
https://github.com/pytorch/vision/releases/tag/v0.13.1

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 30, 2022
@ofborg ofborg bot requested review from teh, thoughtpolice and tscholak August 30, 2022 20:29
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 30, 2022
@mweinelt mweinelt changed the title python3Packages.torch{,-bin}: 1.11.0 -> 1.12.1 Update pytorch (1.12.1), torchaudio (1.13.1), torchvision (0.12.1) Aug 30, 2022
@ofborg ofborg bot requested a review from junjihashimoto August 30, 2022 21:32
@mweinelt mweinelt marked this pull request as ready for review August 30, 2022 21:46
@mweinelt mweinelt mentioned this pull request Aug 30, 2022
Merged
13 tasks
junjihashimoto
junjihashimoto approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@junjihashimoto junjihashimoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Great job!

@bobby285271 bobby285271 added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 31, 2022
SuperSandro2000
SuperSandro2000 approved these changes Aug 31, 2022
View reviewed changes
pkgs/development/python-modules/torch/default.nix Outdated
Comment on lines 250 to +251
Copy link
Member

@SuperSandro2000 SuperSandro2000 Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this a multi line string?

tpwrules
tpwrules approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@tpwrules tpwrules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed building and a very basic smoke test on aarch64-darwin and x86_64-linux with CUDA acceleration.

mweinelt
mweinelt commented Aug 31, 2022
View reviewed changes
@ofborg ofborg bot requested a review from junjihashimoto August 31, 2022 21:48
@mweinelt
python3Packages.torch: 1.11.0 -> 1.12.1
9b18357 
https://github.com/pytorch/pytorch/releases/tag/v1.12.0
https://github.com/pytorch/pytorch/releases/tag/v1.12.1
@mweinelt
python3Packages.torch-bin: 1.11.0 -> 1.12.1
4b37958 
https://github.com/pytorch/pytorch/releases/tag/v1.12.0
https://github.com/pytorch/pytorch/releases/tag/v1.12.1
@mweinelt
python3Packages.torchaudio: 0.11.0 -> 0.12.1
8d3b89d 
https://github.com/pytorch/audio/releases/tag/v0.12.0
https://github.com/pytorch/audio/releases/tag/v0.12.1
@mweinelt
python3Packages.torchvision-bin: 1.12.0 -> 1.13.1
5863492 
https://github.com/pytorch/vision/releases/tag/v0.13.0
https://github.com/pytorch/vision/releases/tag/v0.13.1
@mweinelt
python3Packages.torchvision: 1.13.0 -> 1.13.1
aba6cd1 
https://github.com/pytorch/vision/releases/tag/v0.13.1
@mweinelt mweinelt merged commit 034175e into NixOS:master Aug 31, 2022
@mweinelt mweinelt deleted the torch-1.12.1 branch August 31, 2022 22:13
@rehno-lindeque rehno-lindeque mentioned this pull request Sep 5, 2022
Closed
14 tasks
@rehno-lindeque rehno-lindeque mentioned this pull request Sep 5, 2022
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@teh teh Awaiting requested review from teh

@tscholak tscholak Awaiting requested review from tscholak

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@junjihashimoto junjihashimoto Awaiting requested review from junjihashimoto

+1 more reviewer

@tpwrules tpwrules tpwrules approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mweinelt @tpwrules @junjihashimoto @SuperSandro2000 @bobby285271